Add custom headers for audit trail #556
Conversation
There was a problem hiding this comment.
Looks good. Just to check one other thing - say I want to send something like an API key in a header, can I use the sensitive() function to mark the header value as sensitive, and it'll be correctly masked in the Terraform logs and in our resource changes view?
Probably a stupid question, but figured I'd ask.
| "custom_headers": { | ||
| Type: schema.TypeMap, | ||
| Optional: true, | ||
| Description: "`custom_headers` is a Map of key values strings, that will be passed as headers with audit trail call.", |
There was a problem hiding this comment.
I wonder if this should be "with the audit trail call", or "with audit trail calls"? Maybe we should use the word "request" instead of "call" as well?
|
|
I think we are going to change API a bit, so possible this implementation will be changed |
Co-authored-by: Elie CHARRA <[email protected]>
There was a problem hiding this comment.
It looks good - I'd maybe be tempted to hold off merging until the frontend changes are made to support this. Otherwise it could be a little confusing because you'd be able to configure this via TF, but wouldn't be able to see that the headers had been configured anywhere in the UI.
|
lets close it for now |
Description of the change
Type of change
Checklists
Development
false.)go generateto make sure the docs are up to dateCode review