Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting non-existing stack dependency references #538

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

marcinwyszynski
Copy link
Contributor

Description of the change

If the stack or the dependency is removed manually, it will not be possible to delete stack dependency reference. Throughout the rest of the provider we use a consistent pattern of just removing these resources from the state, and not treating it as an error. We will emit a warning here in case anyone misses the old error messages, but otherwise let's have this resource behave like all other resources.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

peterdeme
peterdeme previously approved these changes Apr 23, 2024
@peterdeme peterdeme requested a review from a team April 23, 2024 18:52
@marcinwyszynski marcinwyszynski added the bug Something isn't working label Apr 25, 2024
@marcinwyszynski marcinwyszynski force-pushed the deleting-stack-dependency-references branch from a5e5878 to 2bb795e Compare April 29, 2024 14:22
@marcinwyszynski marcinwyszynski merged commit 4765ad4 into main Apr 29, 2024
7 checks passed
@marcinwyszynski marcinwyszynski deleted the deleting-stack-dependency-references branch April 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants