Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Intend to implement: window/progress #947

Closed
felixfbecker opened this issue Nov 12, 2018 · 0 comments
Closed

Intend to implement: window/progress #947

felixfbecker opened this issue Nov 12, 2018 · 0 comments
Labels
design Design-oriented issues. It is not a design work request (use 'needs-design' instead) extensions Sourcegraph extensions webapp

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Nov 12, 2018

For TypeScript dependency installation it would be useful to report progress, so we can answer requests without needing to do ugly heuristics.

Here's what the Rust language server already sends:

https://github.com/rust-lang-nursery/rls/blob/0e7432a4ff58bf3584c44bdb390d557cee846968/src/lsp_data.rs#L366-L393

LSP issue: microsoft/language-server-protocol#70
LSP proposal: microsoft/language-server-protocol#245
vscode-languageserver-node PR that implements what Rust sends: https://github.com/Microsoft/vscode-languageserver-node/pull/261/files#diff-663e3c81ec938b18f2ab1cd4b47055f0R21 (we could copy the protocol/src/protocol.progress.proposed.ts file for our use cases)

This needs an extension API for reporting progress, like https://code.visualstudio.com/docs/extensionAPI/vscode-api#window.withProgress

@francisschmaltz could you help with designing this?

@felixfbecker felixfbecker added webapp extensions Sourcegraph extensions design Design-oriented issues. It is not a design work request (use 'needs-design' instead) labels Nov 12, 2018
BolajiOlajide pushed a commit that referenced this issue Apr 16, 2024
Snapshot Restore generates commands to restore dumped snapshots to a Sourcegraph instance
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Design-oriented issues. It is not a design work request (use 'needs-design' instead) extensions Sourcegraph extensions webapp
Projects
None yet
Development

No branches or pull requests

2 participants