Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing kernel.local_aware tags for definitions that impleme… #542

Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix: Add missing kernel.local_aware tags for definitions that impleme… #542

merged 1 commit into from
Aug 9, 2022

Conversation

temp
Copy link
Contributor

@temp temp commented Aug 9, 2022

…nt the LocaleAwareInterface

Subject

Fixes the issue described in #541

I am targeting this branch, because the problem appeared with version 2.13.0.

Closes #541 .

Changelog

### Fixed
- Add missing kernel.local_aware dependency injection container tags for definitions that implement symfony's LocaleAwareInterface.

@VincentLanglet VincentLanglet requested a review from a team August 9, 2022 10:18
Hanmac
Hanmac approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@Hanmac Hanmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VincentLanglet VincentLanglet merged commit 9bed396 into sonata-project:2.x Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@Hanmac Hanmac Hanmac approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sonata\IntlBundle\Helper\BaseHelper::getLocale() problem
4 participants
@temp @Hanmac @jordisala1991 @VincentLanglet