Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hint and final keyword #539

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Add type hint and final keyword #539

merged 2 commits into from
Aug 6, 2022

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Aug 6, 2022 •
edited
Loading

Subject

Changelog

### Added
- final keyword to all classes
- typehint to all methods

@VincentLanglet VincentLanglet force-pushed the addTypeHintFinal branch 3 times, most recently from 53d0ca0 to 71a7183 Compare August 6, 2022 19:41
@VincentLanglet VincentLanglet requested review from jordisala1991 and a team August 6, 2022 19:55
@VincentLanglet VincentLanglet marked this pull request as ready for review August 6, 2022 19:55
@VincentLanglet VincentLanglet mentioned this pull request Aug 6, 2022
Closed
28 tasks
@VincentLanglet
Copy link
Member Author

After this, I think we're ready for an alpha @jordisala1991

@VincentLanglet VincentLanglet merged commit 277f97c into sonata-project:3.x Aug 6, 2022
@VincentLanglet VincentLanglet deleted the addTypeHintFinal branch August 6, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @jordisala1991