Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON-RPC documentation #7915

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

CriesofCarrots
Copy link
Contributor

Problem

JSON-RPC documentation has not remained current with implementation. A more programmatic solution is being explored (#7866), but in the meantime, the current solution ought to reflect reality.

Summary of Changes

  • Update JSON-RPC documentation
  • Also sneak in an improvement to getBlockCommitment clunkiness, discovered when updating docs:
Before:
"result":{"commitment":{"commitment":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,10,32]},"totalStake": 42}"
result":{"commitment":null,"totalStake": 42}

After:
"result":{"commitment":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,10,32],"totalStake": 42}
"result":{"commitment":null,"totalStake": 42}

Fixes #7808

@CriesofCarrots CriesofCarrots requested a review from mvines January 22, 2020 02:39
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@CriesofCarrots CriesofCarrots merged commit 7a132ea into solana-labs:master Jan 22, 2020
@CriesofCarrots CriesofCarrots deleted the rpc-more branch February 21, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-RPC documents need updating
2 participants