Update uid2 dependency from 0.0.3 to 1.0.0 #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
uid2dependency from 0.0.3 to 1.0.0 (its latest release) which has the following changes (see its HISTORY.md for full details):crypto.randomBytesinstead ofcrypto.pseudoRandomBytescoreh/uid2@e492a9d-_to generated unique IDs coreh/uid2@a3b8defThe first change would only matter to clients that are using a version of node < 4.0.0, but this repo only supports >= 10 so that's not really a problem. This does also future-proof this repo a bit where while the
crypto.pseudoRandomBytesdoes work, it's undocumented in thecryptodocs, ascrypto.randomBytesshould work essentially the same, unless you ran it exactly at system boot time, in which it'll then block execution till enough entropy has built up.The second case could matter if someone was for some reason relying on the exact shape of the generated IDs, but that seems unlikely, and the internal code doesn't have any issues with the two additional characters.