Extend unit tests #165
Extend unit tests #165
Conversation
| @@ -13,6 +13,12 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| func TestMain(m *testing.M) { | |||
There was a problem hiding this comment.
This is great! I didn't know of TestMain!
There was a problem hiding this comment.
Credit goes to Robert for this one
|
Thanks @adatzer you've pointed out some useful things here. Going to take another pass at them tomorrow and see if I can improve this PR a bit.
I think I initially did it that way as it's not testing a file named variables, it's a set of variables for tests. But I dunno if that actually makes any sense - I'll think about it after I address the comments. |
|
Thanks for very useful comments @adatzer - I'm a lot happier with the state of affairs now. I think I've addressed everything now, should be ready for another pass. |
| if err == nil { | ||
| t.Fatalf("expected error, got nil") | ||
| } | ||
| assert.NotNil(err) |
There was a problem hiding this comment.
nit - can we use the new if err != nil pattern here as well?
There was a problem hiding this comment.
Yeah looks like I missed a few like this. Fixing
colmsnowplow
force-pushed
the
extend-unit-tests
branch
from
ea0c004 to
8f69ca4
Compare
This PR replaces #139, as it required a rebase and it was simple to just create a new PR.