Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make anything that doesn't need to be exported private #111

Closed
colmsnowplow opened this issue Apr 26, 2022 · 0 comments
Closed

Make anything that doesn't need to be exported private #111

colmsnowplow opened this issue Apr 26, 2022 · 0 comments
Labels
refactor Suggestion of a better way to factor the code
Milestone
Release 1.0.0

Comments

@colmsnowplow
Copy link
Collaborator

Some objects are exported where they don't need to be. For example, some of the 'with interfaces' functions, which allow for easier testing, don't need to be exported as they're only used internally to their specific packages.

We should audit the codebase for what should be private and what needs to be public.
@colmsnowplow colmsnowplow mentioned this issue Apr 26, 2022
Closed
@colmsnowplow colmsnowplow added this to the Release 1.0.0 milestone May 10, 2022
TiganeteaRobert added a commit that referenced this issue Jun 10, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
857986b
TiganeteaRobert added a commit that referenced this issue Jun 10, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
e169802
TiganeteaRobert added a commit that referenced this issue Jun 10, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
50107e2
TiganeteaRobert added a commit that referenced this issue Jun 10, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
42a778b
TiganeteaRobert added a commit that referenced this issue Jun 10, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
2b41407
TiganeteaRobert added a commit that referenced this issue Jun 10, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
be2bf87
TiganeteaRobert added a commit that referenced this issue Jun 22, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
6ee305d
TiganeteaRobert added a commit that referenced this issue Jun 22, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
f87e0de
TiganeteaRobert added a commit that referenced this issue Jun 22, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
fa41529
TiganeteaRobert added a commit that referenced this issue Jun 22, 2022
@TiganeteaRobert
Make anything that doesn't need to be exported private (closes #111)
33ec70e
@colmsnowplow colmsnowplow added the refactor Suggestion of a better way to factor the code label Jun 24, 2022
colmsnowplow pushed a commit that referenced this issue Jul 6, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
2d37b03
colmsnowplow pushed a commit that referenced this issue Jul 6, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
77784da
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
7c658ad
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
9266306
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
83b6e11
colmsnowplow pushed a commit that referenced this issue Jul 22, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
2e131ba
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
61fb78a
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
dfbfe43
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
a892156
colmsnowplow pushed a commit that referenced this issue Aug 12, 2022
@TiganeteaRobert @colmsnowplow
Make anything that doesn't need to be exported private (closes #111)
8f3e0c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Suggestion of a better way to factor the code
Projects
None yet
Milestone
Release 1.0.0
Development

No branches or pull requests
1 participant
@colmsnowplow