Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1526510: Adjust DSN, OCSP and Privatelink domains for CN deployment #1178

Merged
merged 9 commits into from
Jul 15, 2024
Merged

SNOW-1526510: Adjust DSN, OCSP and Privatelink domains for CN deployment #1178

merged 9 commits into from
Jul 15, 2024
+380 −57

Conversation

sfc-gh-dheyman
Copy link
Collaborator

Description

SNOW-1526510: Adjust DSN, OCSP and Privatelink domains for CN deployment

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.86047% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (d5655f3) to head (a3ced53).

Files Patch % Lines
connection_util.go 82.60% 4 Missing ⚠️
connection.go 50.00% 1 Missing ⚠️
driver.go 80.00% 1 Missing ⚠️
dsn.go 98.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
- Coverage   83.07%   83.03%   -0.04%     
==========================================
  Files          54       54              
  Lines       12578    12626      +48     
==========================================
+ Hits        10449    10484      +35     
- Misses       2129     2142      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dheyman sfc-gh-dheyman marked this pull request as ready for review July 11, 2024 12:55
@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner July 11, 2024 12:55
sfc-gh-astachowski
sfc-gh-astachowski reviewed Jul 11, 2024
View reviewed changes
connection_util.go Outdated Show resolved Hide resolved
dsn.go Outdated Show resolved Hide resolved
dsn.go Outdated Show resolved Hide resolved
dsn.go Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Jul 15, 2024
View reviewed changes
connection_test.go Show resolved Hide resolved
connection_util.go Show resolved Hide resolved
dsn.go Show resolved Hide resolved
@sfc-gh-dheyman sfc-gh-dheyman merged commit f2164e5 into master Jul 15, 2024
36 of 38 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-1526510-cn-domain branch July 15, 2024 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dheyman @sfc-gh-pmotacki @sfc-gh-pfus @sfc-gh-astachowski