-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support staticcheck lint:ignore and lint:file-ignore directives #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR. I only have some nits before this can be merged, no functional concerns.
Worth noting to future readers that bazel-contrib/rules_go#3562 also exists in rules_go as a way to ignore lint check. However, this PR implements staticcheck
specific ignore directive which is a bit nicer.
Co-authored-by: Son Luong Ngoc <[email protected]>
Co-authored-by: Son Luong Ngoc <[email protected]>
I had been looking for ways to ignore lint checks, and didn't know about that PR. I'll probably open a PR against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sluongng would it be possible to cut a new release including this PR? |
Based loosely on https://github.com/dominikh/go-tools/blob/master/lintcmd/lint.go