Fix #875 Proper support UTF8 payloads #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johann-sonntagbauer
commented
Oct 20, 2015
johann-sonntagbauer
commented
- introduced new dependency "text-encoding"
- delegate encoding operations to TextEncoder/TextDecoder
- added unit test to verify proper utf-8 encoding
* introduced new dependency "text-encoding" * delegate encoding operations to TextEncoder/TextDecoder * added unit test to verify proper utf-8 encoding
|
Strange the testcase works on my machine. Is there some problem with the test environment? |
|
It sometimes happens that the builds fail. I'll restart it. |
|
:D thx |
|
This looks good to merge to me. |
fatso83
added a commit
that referenced
this pull request
Oct 22, 2015
Fix #875 Proper support UTF8 payloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.