Add test for #1796, failing to stub Array.prototype.sort #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed in c2c7814
Pull Request Test Coverage Report for Build 2625
💛 - Coveralls |
fearphage
requested changes
Aug 8, 2018
test/issues/issues-test.js
Outdated
| describe("#1796 - cannot stub Array.prototype.sort", function () { | ||
| it("it should not fail with RangeError", function () { | ||
| var stub = sinon.stub(Array.prototype, "sort"); | ||
| [1, 2, 3].sort(); |
There was a problem hiding this comment.
All tests should have assertions. Assert that this doesn't throw.
There was a problem hiding this comment.
Good point. I've added an extra commit. Once happy with this PR, I'll fold the commits together
fearphage
reviewed
Aug 8, 2018
|
|
||
| describe("#1796 - cannot stub Array.prototype.sort", function () { | ||
| it("it should not fail with RangeError", function () { | ||
| var stub = sinon.stub(Array.prototype, "sort"); |
There was a problem hiding this comment.
Does this stub need to .callThrough() (like the linked issue) to trigger the RangeError?
There was a problem hiding this comment.
Nope, .callThrough() is not necessary to trigger the RangeError.
fearphage
requested changes
Aug 8, 2018
test/issues/issues-test.js
Outdated
| it("it should not fail with RangeError", function () { | ||
| refute.exception(function () { | ||
| var stub = sinon.stub(Array.prototype, "sort"); | ||
| [1, 2, 3].sort(); |
There was a problem hiding this comment.
This should be the only line that we are concerned with not throwing an exception.
There was a problem hiding this comment.
Correct, I've pushed a commit that fixes that
fearphage
approved these changes
Aug 8, 2018
|
Dang, I merged without squashing ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows that the issue described in #1796 has been fixed (in c2c7814)
Once this is merged, we should create a new release.
How to verify - mandatory
npm installnpm testChecklist for author
npm run lintpasses