Fix onerror event triggering for fake xhr requests #1041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
The
xhr.onerror
event was not firing at all.Background (Problem in detail) - optional
I cam across this issue while looking into #1040 and #1031. There are a finite number of
xhr.on__event__
hooks that sinon was checking andonerror
was not on the list.Note: There is talk of errors being triggered at the wrong time in sinon. I did not address that at all. This only makes
xhr.onerror
trigger when anerror
event is triggered. I added additional tests to ensure the order and make sure this stays functional in the future.Solution
Added
error
event to sequence of events looked for on xhr object (xhr['on' + name]
).How to verify - mandatory
npm install
npm test