Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #59 #62

Closed
wants to merge 3 commits into from
Closed

Conversation

rogierschouten
Copy link
Contributor

No description provided.

@fatso83
Copy link
Contributor

fatso83 commented May 26, 2016

I'll hold on merging this until we can get a test case from @gautaz. Would like to avoid reintroducing it :-)

P.S. Don't checking the compiled code. That keeps the diffs smaller and easier to look through. We only update the dist when publishing a new version.

@rogierschouten
Copy link
Contributor Author

OK!
On May 26, 2016 20:32, "Carl-Erik Kopseng" [email protected] wrote:

I'll hold on merging this until we can get a test case from @gautaz
https://github.com/gautaz. Would like to avoid reintroducing it :-)

P.S. Don't checking the compiled code. That keeps the diffs smaller and
easier to look through. We only update the dist when publishing a new
version.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#62 (comment)

@rogierschouten
Copy link
Contributor Author

@fatso83 test incorporated. It failed when I undid my fix and it passes now.

@rogierschouten rogierschouten mentioned this pull request May 27, 2016
fatso83 added a commit that referenced this pull request Jul 13, 2016
@fatso83
Copy link
Contributor

fatso83 commented Jul 13, 2016

Sorry for taking this long to merge this! Had to rebase so merged as #74.

@fatso83 fatso83 closed this Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants