Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node.js 12 compatibility #13

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Fix Node.js 12 compatibility #13

merged 2 commits into from
Feb 1, 2020

Conversation

benjamingr
Copy link
Collaborator

@benjamingr benjamingr commented Jan 22, 2020 •
edited by sindresorhus
Loading

Hey, the tests broke on Node 13 (fixes #12 ) because we don't hit the IC enough :]

@benjamingr benjamingr mentioned this pull request Jan 23, 2020
Open
@sindresorhus sindresorhus changed the title Make test pass in Node 13 Make test pass in Node.js 13 Jan 25, 2020
@sindresorhus sindresorhus changed the title Make test pass in Node.js 13 Fix Node.js 12 compatibility Jan 26, 2020
@sindresorhus sindresorhus merged commit 1984e36 into master Feb 1, 2020
@sindresorhus sindresorhus deleted the fix-fox-node-13 branch February 1, 2020 09:42
@sindresorhus
Copy link
Owner

Thanks :)

@benjamingr
Copy link
Collaborator Author

Sure thing 😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail with Node.js >= 12
2 participants
@benjamingr @sindresorhus