Fix timeout option not leaving early when on sleep mode

[GMartigny]

Fix #157
Add regression test

[ehmicky]

This looks good, except the tests are failing on CI.

[ehmicky]

Thanks a lot for the PR Guillaume! I've just reviewed it. Looking forward to merge this fix.

[GMartigny]

As for the tests, they're working on local. I could remove the "leaving early" test. I thought that checking 2000ms over 500ms expected was safe enough. I'll try to extends the margin first, but I might have to remove this test (which remove the regression test).

[ehmicky]

You can try to use test.serial() as well to ensure no other tests are running concurrently. This will ensure more predictable timing.

[ehmicky]

This looks good to me now. Just waiting for @sindresorhus review before merging it :)

Thanks! 👏

[sindresorhus]

This is better known as a deferred, and is usually considered a bad practice: https://github.com/petkaantonov/bluebird/wiki/Promise-Anti-patterns#the-deferred-anti-pattern

I haven't looked closely into the changes here, but maybe there's a way to solve it without using a deferred? If not, that's fine too. Sometimes it's needed. But usually when someone grabs for a deferred, there's usually a better way.

[GMartigny]

I think we fall into the "it's needed" case.

You might have to use a deferred object when wrapping a callback API that doesn't follow the standard convention. Like setTimeout.

The goal is to resolve as soon as the process complete or the setTimeout ends. I could use some kind of cancellation, but I don't see any better solution right now.

[sindresorhus]

Yeah, I don't see a better way either. I was just trying my luck in case you could think of a better way.

[sindresorhus]

This is looking good. Thanks for contribution, @GMartigny 👌