Update instuctions for usage with spring to suggest Rails.application.eager_load! #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cleaner solution to usage with spring than copying simple cov start code to config/spring.rb. According to suggestion here simplecov-ruby#381 (comment) and here https://stormconsultancy.co.uk/blog/development/ruby-on-rails/getting-accurate-code-coverage-metrics-from-simplecov-rails-project/
PragTob
reviewed
May 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleaner solution to usage with spring than copying
SimpleCov.startcode toconfig/spring.rb. 🍝According to suggestion from @ibrahima here #381 (comment)
and @adampope here https://stormconsultancy.co.uk/blog/development/ruby-on-rails/getting-accurate-code-coverage-metrics-from-simplecov-rails-project/
I took a chance and removed the current instruction because I felt it wasn't as good, but I'll gladly add it back if you feel that both should be there. 😇
I'm not sure if there are any cons to calling eager load here so it would be good to hear from more people if this is a good solution. 📣
For my rails project I got 0% coverage until I copied
SimpleCov.start if Rails.env.test?intoconfig/spring.rb, then I looked around until I found the eager load solution. I also tried withDISABLE_SPRING=1as suggested here #381 (comment) but that didn't seem to do anything.