Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48 separate cad definition and meshing #107

Merged
merged 11 commits into from
Jan 2, 2025
Merged

48 separate cad definition and meshing #107

merged 11 commits into from
Jan 2, 2025

Conversation

simbilod
Copy link
Owner

@simbilod simbilod commented Jan 1, 2025

further refactor Model to allow separation of cad definition and meshing

other improvements suggest themselves:

  • registering entities inside the model (with a method) instead of passing a model to entities
  • rethink model initialization; now we clear and create new ones so it always works, but this might have issues when we work on different models in parallel in the future

@simbilod simbilod linked an issue Jan 1, 2025 that may be closed by this pull request
separate CAD definition and meshing #48
Closed
@simbilod simbilod mentioned this pull request Jan 1, 2025
Closed
@simbilod simbilod merged commit e14cf8e into main Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

separate CAD definition and meshing
1 participant
@simbilod