Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #617

Merged
merged 1 commit into from
Dec 2, 2024
+6 −6
Merged

API Explicity mark nullable parameters for PHP 8.4 #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Extensions/FileSubsites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function alternateTreeTitle()
* @param SQLSelect $query
* @param DataQuery|null $dataQuery
*/
protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
protected function augmentSQL(SQLSelect $query, ?DataQuery $dataQuery = null)
{
if (Subsite::$disable_subsite_filter) {
return;
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/GroupSubsites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ protected function updateTreeTitle(&$title)
* @param SQLSelect $query
* @param DataQuery|null $dataQuery
*/
protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
protected function augmentSQL(SQLSelect $query, ?DataQuery $dataQuery = null)
{
if (Subsite::$disable_subsite_filter) {
return;
Expand Down
4 changes: 2 additions & 2 deletions src/Extensions/LeftAndMainSubsites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public function shouldChangeSubsite($adminClass, $recordSubsiteID, $currentSubsi
*
* @param Member $member
*/
protected function canAccess(Member $member = null)
protected function canAccess(?Member $member = null)
{
if (!$member) {
$member = Security::getCurrentUser();
Expand Down Expand Up @@ -256,7 +256,7 @@ protected function canAccess(Member $member = null)
*
* @param Member $member
*/
public function alternateAccessCheck(Member $member = null)
public function alternateAccessCheck(?Member $member = null)
{
return $this->canAccess($member);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/SiteConfigSubsites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class SiteConfigSubsites extends Extension
* @param SQLSelect $query
* @param DataQuery|null $dataQuery
*/
protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
protected function augmentSQL(SQLSelect $query, ?DataQuery $dataQuery = null)
{
if (Subsite::$disable_subsite_filter) {
return;
Expand Down
2 changes: 1 addition & 1 deletion src/Extensions/SiteTreeSubsites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function isMainSite()
* @param SQLSelect $query
* @param DataQuery $dataQuery
*/
protected function augmentSQL(SQLSelect $query, DataQuery $dataQuery = null)
protected function augmentSQL(SQLSelect $query, ?DataQuery $dataQuery = null)
{
if (Subsite::$disable_subsite_filter) {
return;
Expand Down
Loading