Fix CJS type import when moduleResolution is node16 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types right now currently don't work if the user is using node16 moduleResolution in a CJS project: https://arethetypeswrong.github.io/?p=gqtx%400.9.3
andrew0
commented
Dec 27, 2023
| }, | ||
| "./package.json": "./package.json", | ||
| "./": "./" |
There was a problem hiding this comment.
VS Code gave a warning for this saying "Property ./ is not allowed."
andrew0
commented
Dec 27, 2023
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
| "compilerOptions": { | |||
| "outDir": "dist/cjs", | |||
| "declaration": false | |||
There was a problem hiding this comment.
I tried using the same type definition files for both require and import, but then TypeScript thinks that the type definitions are for ESM even in CJS mode, so it won't let you import it in a CJS app.
|
@andrew0 This is amazing - appreciate your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types right now currently don't work if the user is using node16 moduleResolution in a CJS project:
https://arethetypeswrong.github.io/?p=gqtx%400.9.3
After running
yarn build && cd dist && npx @arethetypeswrong/cli --packwith this change: