refactor: drop usage of objcopy to generate UKIs #10102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings native implementation without external dependencies. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
refactor/native-objcopy
branch
from
9b913e5 to
dc2b547
Compare
smira
changed the title
frezbo
reviewed
Jan 10, 2025
frezbo
reviewed
Jan 10, 2025
frezbo
approved these changes
Jan 10, 2025
dsseng
approved these changes
Jan 10, 2025
| return fmt.Errorf("failed to read DOS header: %w", err) | ||
| } | ||
|
|
||
| binary.LittleEndian.PutUint32(dosheader[0x3c:], 0x80) |
There was a problem hiding this comment.
Maybe label constants used here?
There was a problem hiding this comment.
yes, good point, I can do some constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings native implementation without external dependencies.