updated go version to 1.21 #225
Conversation
pull-request-size
bot
added
the
size/XS
|
.github/workflows/release.yml
Outdated
| @@ -43,7 +43,7 @@ jobs: | |||
| - name: Run GoReleaser | |||
| uses: goreleaser/goreleaser-action@v2 | |||
| with: | |||
| version: v1.18.2 | |||
There was a problem hiding this comment.
im not too sure about this being ideal, I opened #227 so dependabot can take care of it.
There was a problem hiding this comment.
I think this will not be tackled by the Dependabot automation. I would actually suggest to remove the version here as we don't want to pin the GoReleaser version unless we have a very good reason. Omitting the value means we default to latest anyway.
There was a problem hiding this comment.
But good catch that this value is clearly wrong here.
There was a problem hiding this comment.
But we have a good reason to pin the GoReleaser version: #204. We should have maybe created an issue at that time, though.
There was a problem hiding this comment.
I wasn't aware, or I forgot about it. But I would suggest we just fix the issue: #233 to get out of that pinning.
There was a problem hiding this comment.
@Adarsh-jaiss Now that we have all understood the implications and with #233 being merged, can you rebase your PR one more time? The change of the version here is no longer needed. Thanks!
.github/workflows/release.yml
Outdated
| @@ -43,7 +43,7 @@ jobs: | |||
| - name: Run GoReleaser | |||
| uses: goreleaser/goreleaser-action@v2 | |||
| with: | |||
| version: v1.18.2 | |||
There was a problem hiding this comment.
@Adarsh-jaiss Now that we have all understood the implications and with #233 being merged, can you rebase your PR one more time? The change of the version here is no longer needed. Thanks!
|
Hey @HeavyWombat , I'm unable to see the previous commits in my local development enviroment, and in order to rebase this, i need to do that, but now i am stuck! otherwise, the only soltuion i have now it to make a new fresh PR with clean changes :( |
There was a problem hiding this comment.
Changes look fine. @HeavyWombat if you insist on your commit history requirement, please work with @Adarsh-jaiss.
/approve
openshift-ci
bot
added
the
approved
Signed-off-by: adarsh-jaiss <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat, SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes