Update BuildAh to v1.23.1

[SaschaSchwarze0]

Changes

I cherry-picked the changes from update buildah image to v1.23.1 #951. In my local tries, the BuildAh build was hanging as well like in the GitHub action runs. No indication for me why. Low resources was my guess, and with more resources it succeeded.

fyi @wanjunlei

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Update Buildah to 1.23.1, introduce parameters to setup registry configuration

[SaschaSchwarze0]

Hi @adambkaplan, @gabemontero, @HeavyWombat, may somebody please have a look at this one? Thank you.

[gabemontero]

/approve

@SaschaSchwarze0 should we update the e2e tests that use samples/buildrun/buildrun_buildah_cr.yaml to exercise the new parameters?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SaschaSchwarze0]

@SaschaSchwarze0 should we update the e2e tests that use samples/buildrun/buildrun_buildah_cr.yaml to exercise the new parameters?

Valid question. I am not too familiar with them so far (that part I took from the other PR, I only increased the resources to make it functional again):

• For registry-search we probably need a Dockerfile with a FROM that consumes from for example our samples but without the ghcr.io prefix. And then we set registry-search to ghcr.io and it should work?
• For registry-insecure, I am not sure. In our kind cluster we use an instance of registry:2 without HTTPS = it is insecure, but those tests passed all the time.
• For registry-block we would need a negative test that expects a buildrun to fail when we block the host of a FROM image.

I would put that into a separate issue. I would actually want to tackle this after the array parameters are merged because we can then change the parameters that are introduced here to arrays as that's what they all should be. And then we can also add build-args in that step and only need to touch everything once.

[gabemontero]

@SaschaSchwarze0 should we update the e2e tests that use samples/buildrun/buildrun_buildah_cr.yaml to exercise the new parameters?

Valid question. I am not too familiar with them so far (that part I took from the other PR, I only increased the resources to make it functional again):

* For `registry-search` we probably need a Dockerfile with a FROM that consumes from for example our samples but without the `ghcr.io` prefix. And then we set registry-search to ghcr.io and it should work?

* For `registry-insecure`, I am not sure. In our kind cluster we use an instance of registry:2 without HTTPS = it is insecure, but those tests passed all the time.

* For `registry-block` we would need a negative test that expects a buildrun to fail when we block the host of a FROM image.

I would put that into a separate issue. I would actually want to tackle this after the array parameters are merged because we can then change the parameters that are introduced here to arrays as that's what they all should be. And then we can also add build-args in that step and only need to touch everything once.

separate issue works for me @SaschaSchwarze0

I'll open it shortly, unless you beat me to it.

/lgtm

[SaschaSchwarze0]

I'll open it shortly, unless you beat me to it.

Thanks @gabemontero. I bet you already. Issue is #988. :-)

[gabemontero]

you did beat me to it :-)

#988