Update Verify CI job to check CRD generation #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note-none
shahulsonhal
added
the
kind/cleanup
HeavyWombat
requested changes
Nov 22, 2021
There was a problem hiding this comment.
Thanks for the work here. So @SaschaSchwarze0 and I were looking into this PR and we were wondering: It would make more sense to refactor the current setup in the following way:
- Only have one Makefile target for generation:
make generate. This should generate both the CRDs and the client code. - Also, only have one verify target:
make verify-generate. Same idea, check both uncommited/unstaged changes for CRDs and the client code.
As a side effect, this should simplify the whole setup and number of targets.
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code. Fixes shipwright-io#943 Update hack/verify-generate.sh to check CRDs and deep copy generation Update deep copy generation file not in sync
shahulsonhal
force-pushed
the
crd-verify
branch
from
1a000ad to
8c764af
Compare
shahulsonhal
force-pushed
the
crd-verify
branch
from
8c764af to
9f1f57a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have a Verify CI job that runs the basic static analysis, like code linting. This step should also ensure that CRD definitions for the Build APIs are aligned with what is in the golang code.
Fixes #943
Update hack/verify-generate.sh to check CRDs and deep copy generation
Update deep copy generation file not in sync
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes