Fix nil-pointer dereference of BuildSpec Strategy #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were cases in which the Build had a `nil` Strategy, which is copied into the BuildRun `Status.BuildSpec` and later used internally, for example the metrics code is using the `Strategy` field. In case it is `nil`, the function call for the metrics failed with a nil-pointer dereference. Introduce `BuildSpec` convenience function called `StrategyName` to return the name of the strategy, which includes a `nil` safety check. Replace all occurrences of `BuildSpec.Strategy.Name` with the newly introduced function to avoid panics.
openshift-ci-robot
added
the
release-note
|
/retest |
|
Let me try to reopen to re-trigger the test. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There were cases in which the Build had a
nilStrategy, which is copied intothe BuildRun
Status.BuildSpecand later used internally, for example themetrics code is using the
Strategyfield. In case it isnil, the functioncall for the metrics failed with a nil-pointer dereference.
Introduce
BuildSpecconvenience function calledStrategyNameto return thename of the strategy, which includes a
nilsafety check.Replace all occurrences of
BuildSpec.Strategy.Namewith the newly introducedfunction to avoid panics.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes