-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informers and listers for the advanced usages #642
Add informers and listers for the advanced usages #642
Conversation
@zhangtbj is not "Simplify the generated clientset folder from pkg/client/build to pkg/client directly" a breaking change that needs special consideration in the release note? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @SaschaSchwarze0 , yes, I added the package change in the release note. |
Reviewing later today, xiexie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
In future, the Shipwright Build may be used by other clients, or we will have more advanced usages by leveraging the lister.
Let us add the informers and listers as a complete open-source controller
What I did in the PR:
generate-codegen.sh
to a common nameupdate-codegen.sh
informer
andlister
in the update-codegen.shpkg/client/build
topkg/client
directlyverify-codegen.sh
and verify if it is correct now (Of course, this verify-codegen.sh can be executed in each PR verification, but we can do that in future PR):README.md
in the hack folder to introduce all scripts.Submitter Checklist
/kind enhancement
Release Notes