Change error messages start with a lower case letter

[zhangtbj]

I am providing the error message list for our service.

I found most of the error messages start with a lower case letter, but few of them forget to correct the format, like:
Updating predicated passed, the annotation was modified.

So I format all related error messages in the controller as same message style:
Change error messages start with a lower case letter

[zhangtbj]

Hi all,

Does anyone know how to re-run the Travis test for my PR (I cannot find the restart button in Travis now):
https://travis-ci.org/github/shipwright-io/build/builds/737280956
Thanks!

[SaschaSchwarze0]

Hi all,

Does anyone know how to re-run the Travis test for my PR (I cannot find the restart button in Travis now):
https://travis-ci.org/github/shipwright-io/build/builds/737280956
Thanks!

I see the restart button (you probably need to login ?), but that won't help unless you fix the test failures like this one:

  Expected

      <string>: "the Bu..."

  to equal       |

      <string>: "The Bu..."

  /home/travis/gopath/src/github.com/shipwright-io/build/pkg/controller/buildrun/buildrun_controller_test.go:651

Also, please enhance the PR description with a rational why you are doing this.

[zhangtbj]

Thank you Sascha!

Yes, correct the UT and add description in the comment.

[qu1queee]

@zhangtbj thanks. This PR is good, but I would encourage you to provide a better fix(you can do that as a second PR). What we should do is to trigger a linter for this types of validations for every PR; for this you could do the following:

• add a new Make target call make staticcheck that runs staticcheck ./...
• ensure that for every travis pr we execute this target, so probably in travis we will need to install the binary, this can be done via:

$ docker run -it havener/build-environment /bin/bash
root@3f8bdf5e61e6:/# curl -s -LO https://github.com/dominikh/go-tools/releases/download/2020.1.3/staticcheck_linux_amd64.tar.gz
root@3f8bdf5e61e6:/# tar xfz staticcheck_linux_amd64.tar.gz --strip-component 1 -C /tmp  staticcheck/staticcheck && ./tmp/staticcheck -h
Usage of staticcheck:
	staticcheck [flags] # runs on package in current directory
	staticcheck [flags] packages
	staticcheck [flags] directory
	staticcheck [flags] files... # must be a single package
Flags:
  -checks checks
    	Comma-separated list of checks to enable. (default "inherit")
  -debug.cpuprofile file
    	Write CPU profile to file
  -debug.measure-analyzers file
    	Write analysis measurements to file. `file` will be opened for appending if it already exists.
  -debug.memprofile file
    	Write memory profile to file
  -debug.no-compile-errors
    	Don't print compile errors
  -debug.repeat-analyzers num
    	Run analyzers num times
  -debug.unused-graph file
    	Write unused's object graph to file
  -debug.version
    	Print detailed version information about this program
  -explain check
    	Print description of check
  -f format
    	Output format (valid choices are 'stylish', 'text' and 'json') (default "text")
  -fail checks
    	Comma-separated list of checks that can cause a non-zero exit status. (default "all")
  -go version
    	Target Go version in the format '1.x' (default 1.13)
  -show-ignored
    	Don't filter ignored problems
  -tags build tags
    	List of build tags
  -tests
    	Include tests (default true)
  -unused.whole-program
    	Run unused in whole program mode
  -version
    	Print version and exit

[zhangtbj]

Sounds good, sure, we can do it in a future PR.
Thanks!

[SaschaSchwarze0]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment