Refactor config environment variable override code #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, there was no need to test cases that check whether the config setup including the environment variable overrides work as expected. New changes to the config setup would benefit from some level of unit tests. Introduce basic Ginkgo test suite. Add test cases for the currently possible environment overrides.
Over time, there was some code duplication accumulated for overriding configuration settings using an environment variable. Introduce one common function to do the float slice override. Combine `os.Getenv` and `if` case into one line, where possible.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/assign @sbose78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time, there was some code duplication accumulated for overriding
configuration settings using an environment variable.
Introduce one common function to do the float slice override.
Combine
os.Getenvandifcase into one line, where possible.Introduce basic Ginkgo test suite.
Add test cases for the currently possible environment overrides.