WIP - Use go test for unit testing
#340
Conversation
adambkaplan
commented
Aug 13, 2020
adambkaplan
commented
- move ginkgo tests to "integration" test package
- Rename test-unit to test-integration
- Fix package naming
- Rename test-unit to test-integration - Fix package naming
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Create test-unit makefile target - Refactor metrics test to be a pure golang unit test
|
quick comment on this. I will be generating a new test suite called "integration"(see #322 ) that requires an instance of the build running and a k8s cluster to do k8s client api calls to test scenarios. The current ginkgo "unit-test" cannot belong under integration while is a very different approach. The current ginkgo "unit-test" are hermetic and constrained to what the binary have and do not require a k8s cluster neither an instance of the build operator running. I hope this helps to avoid overlaps. |
openshift-ci-robot
added
the
needs-rebase
|
@adambkaplan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Update unit test to generate coverage profile - Add clean-coverage and coverage-report make targets - Update travis to run unit and integration tests, then generate coverage report. - Remove unnecessary suite_test.go
|
@adambkaplan can we close this one? |
|
/close |
|
@adambkaplan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
