Merge pull request #564 from qu1queee/qu1queee/fix_flaky_test

Fix flaky unit-test spec for Build
shipwright-io · Feb 2, 2021 · 3ec5401 · 3ec5401
2 parents c0bfa60 + a00ab1c
commit 3ec5401
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/validate/secrets.go b/pkg/validate/secrets.go
@@ -3,6 +3,7 @@ package validate
 import (
 	"context"
 	"fmt"
+	"sort"
 	"strings"
 
 	build "github.com/shipwright-io/build/pkg/apis/build/v1alpha1"
@@ -37,6 +38,9 @@ func (s SecretRef) ValidatePath(ctx context.Context) error {
 		}
 	}
 
+	// sorts a list of secret names in increasing order
+	sort.Strings(missingSecrets)
+
 	if len(missingSecrets) > 1 {
 		s.Build.Status.Reason = build.MultipleSecretRefNotFound
 		s.Build.Status.Message = fmt.Sprintf("missing secrets are %s", strings.Join(missingSecrets, ","))