address integration-tests reviews

shipwright-io · Sep 30, 2020 · 2e0e385 · 2e0e385
1 parent 54736d0
commit 2e0e385
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/pkg/controller/buildrun/buildrun_controller.go b/pkg/controller/buildrun/buildrun_controller.go
@@ -421,14 +421,6 @@ func (r *ReconcileBuildRun) Reconcile(request reconcile.Request) (reconcile.Resu
 						)
 
 					}
-
-					// taskrun ramp-up duration (time between taskrun creation and taskrun pod creation)
-					buildmetrics.TaskRunRampUpDurationObserve(
-						buildRun.Status.BuildSpec.StrategyRef.Name,
-						buildRun.Namespace,
-						pod.CreationTimestamp.Time.Sub(lastTaskRun.CreationTimestamp.Time),
-					)
-
 				}
 			}
 

diff --git a/test/e2e/validators.go b/test/e2e/validators.go
@@ -189,7 +189,7 @@ func validateBuildRunToSucceed(
 		Expect(err).ToNot(HaveOccurred(), "Error retrieving a buildRun")
 
 		return testBuildRun.Status.Succeeded
-	}, time.Duration(550*2)*time.Second, 5*time.Second).Should(Equal(trueCondition), "BuildRun did not succeed")
+	}, time.Duration(1100*getTimeoutMultiplier())*time.Second, 5*time.Second).Should(Equal(trueCondition), "BuildRun did not succeed")
 
 	// Verify that the BuildSpec is still available in the status
 	Expect(testBuildRun.Status.BuildSpec).ToNot(BeNil())