Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#715] Stop bottle support for Big Sur #767

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

krendelhoff2
Copy link
Member

Description

Problem: Big Sur is deprecated by Apple.

Solution: Stop bottle support for Big Sur.

Related issue(s)

Resolves #

Related changes (conditional)

  • I checked whether I should update the README

  • I checked whether native packaging works, i.e. native binary packages
    can be successfully built.

Stylistic guide (mandatory)

@krendelhoff2 krendelhoff2 force-pushed the krendelhoff/#715-stop-bottle-big-sur branch from ab87fce to 8266745 Compare December 20, 2023 11:48
@rvem
Copy link
Member

rvem commented Dec 20, 2023

Note that GA is also building some Monterey bottles at the moment, so it should either be removed or updated to use macos-13

@krendelhoff2 krendelhoff2 force-pushed the krendelhoff/#715-stop-bottle-big-sur branch 2 times, most recently from c642e32 to bd2b9a8 Compare December 20, 2023 15:21
Copy link
Collaborator

@DMozhevitin DMozhevitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there is still arm64_big_sur leftover in scripts/update-brew-formulae.sh#21.

Not sure if it really affects the build, but it will be better to get rid of it while we're here.

Problem: Big Sur is deprecated by Apple.

Solution: Stop bottle support for Big Sur.
Problem: our mac machine switched to monterey.

Solution: Build x86 and arm64 bottles on it.
@krendelhoff2 krendelhoff2 force-pushed the krendelhoff/#715-stop-bottle-big-sur branch from a259f78 to 90833c0 Compare December 21, 2023 11:43
@krendelhoff2 krendelhoff2 merged commit fb3cfea into master Dec 21, 2023
1 check passed
@krendelhoff2 krendelhoff2 deleted the krendelhoff/#715-stop-bottle-big-sur branch December 21, 2023 11:53
Sereja313 added a commit that referenced this pull request Dec 21, 2023
Sereja313 added a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants