Generate and publish symbols package #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert espurious changes to appveyor
Closed
|
Thanks! LGTM 👍 |
bartelink
reviewed
Dec 27, 2023
| on: | ||
| branch: /^(main|dev)$/ | ||
| - provider: GitHub | ||
| auth_token: | ||
| secure: p4LpVhBKxGS5WqucHxFQ5c7C8cP74kbNB0Z8k9Oxx/PMaDQ1+ibmoexNqVU5ZlmX | ||
| artifact: /Serilog.*\.nupkg/ | ||
| artifact: /Serilog.*(\.|\.s)nupkg/ |
There was a problem hiding this comment.
FYI \.s? would mean the same thing
There was a problem hiding this comment.
Thanks a lot for the feedback! I was so much finding my way around appveyor that I did not realize this regex coud be simplified.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes modify Serilog.Sinks.File in order to generate symbols package (snupkg). Appveyor configuration is modified in order to collect the new artifact, and also to publish it both to nuget and to github release.
Fixes #194