Add net6.0 target; update test TFMs #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seealso my wall of text re the sister PR (some is related to this): serilog/serilog-sinks-console#145 (comment) |
bartelink
reviewed
Sep 7, 2023
bartelink
reviewed
Sep 7, 2023
bartelink
changed the title
bartelink
requested changes
Sep 7, 2023
Co-authored-by: Ruben Bartelink <[email protected]>
zachrybaker
commented
Sep 7, 2023
bartelink
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM now; can be merged
@zachrybaker once its merged, there will be a dev package automatically produced
General policy is that it gets tried and then subsequently merged to main for release, some low single or double digit days after it's validated
edited to add: nit: we should test on net7.0 here (or stop doing that for the console sink) for consistency
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to support .net 6, and .net 7. .net5.0 is EOL over a year ago.