Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set shared property for rollingfile settings #11

Closed
KyberMage opened this issue Jun 29, 2017 · 4 comments
Closed

Can't set shared property for rollingfile settings #11

KyberMage opened this issue Jun 29, 2017 · 4 comments

Comments

@KyberMage
Copy link

We seem to be able to configure all rollingfile settings except for file sharing. The code for some reason has a preprocessor directive to set it to true or false if SHARED is defined, but it is not and there is no way to set that via code (obviously). We should be able to set this property.

nblumhardt added a commit to nblumhardt/serilog-extensions-logging-file that referenced this issue Jun 29, 2017
@nblumhardt
Copy link
Member

Thanks for the note. Sharing wasn't originally supported for .NET Core, hence the #if. It has been for a while though, so I've just PR'd a change to enable it on all platforms.

Are you able to check out package version 1.1.0-dev-00014 to make sure this works as expected for your target? Should be a safe/low-impact change to push through to master.

@KyberMage
Copy link
Author

@nblumhardt Looks to be working fine.

@nblumhardt
Copy link
Member

Thanks @jajunk

@alexiordan
Copy link

Not working in 3.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants