Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Modeline aligns with fill column in visual-fill-column-mode #672

Closed
3 tasks done
deadcombo opened this issue Oct 8, 2023 · 3 comments
Closed
3 tasks done

[Bug] Modeline aligns with fill column in visual-fill-column-mode #672

deadcombo opened this issue Oct 8, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@deadcombo
Copy link
Contributor

Thank you for the bug report

  • I am using the latest version of doom-modeline related packages.
  • I checked FAQ.
  • You may also try reproduce the issue using clean environment and minimal configurations with
    the command emacs -Q.

Bug description

image
image

These are screenshots of Emacs with only visual-fill-column and doom-modeline installed, using with-emacs.sh.
When visual-fill-column is enabled, the modeline right align breaks and the modeline becomes aligned with the fill column.

Steps to reproduce

  1. Enable doom-modeline-mode
  2. Enable visual-fill-column-mode

Expected behavior

The modeline stays aligned to the right.

OS

Linux

Emacs Version

30 (gccemacs)

Emacs Configurations

None.

Error callstack

No response

Anything else

I'm not sure whether this is an issue with visual-fill-column instead.
@deadcombo deadcombo added the bug Something isn't working label Oct 8, 2023
@Padraic-O-Mhuiris
Copy link

Am also replicating this

@seagle0128
Copy link
Owner

seagle0128 commented Oct 13, 2023 •
edited
Loading

It's not a bug, while the feature of visual-fill-column-mode. Try (setq mode-line-right-align-edge 'right-fringe).

Maybe I should introduce a new option doom-modeline-right-align-edge?

@seagle0128 seagle0128 added good first issue Good for newcomers and removed bug Something isn't working labels Oct 13, 2023
@deadcombo
Copy link
Contributor Author

It's not a bug, while the feature of visual-fill-column-mode. Try (setq mode-line-right-align-edge 'right-fringe).

Maybe I should introduce a new option doom-modeline-right-align-edge?

mode-line-right-align-edge does solve it. I don't think you should create a new option, rather the visual-fill-column author should document his changes affect the mode-line.

seagle0128 added a commit that referenced this issue Oct 17, 2023
@seagle0128
docs: update FAQ.
9428d2c 
see #672.
DennieTeMolder added a commit to DennieTeMolder/.doom.d that referenced this issue Feb 12, 2024
@DennieTeMolder
fill-column-master: keep RHS mode-line on screen
0713d18 
Ref: seagle0128/doom-modeline#672
hlissner added a commit to doomemacs/doomemacs that referenced this issue Jan 9, 2025
@hlissner @unipro
fix(doom-dashboard): vanishing right-hand mode-line
4f8a8e0 
This is due to :align-to factoring in the margins into its alignment,
which is ever changing in the dashboard buffer (or anywhere
visual-fill-column is active).

Even though `mode-line-right-align-edge` was introduced in Emacs 30,
doom-modeline backports so, so its users should benefit from this as
well.

Close: #8114
Fix: #7466
Fix: seagle0128/doom-modeline#668
Fix: seagle0128/doom-modeline#672
Co-authored-by: unipro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seagle0128 @deadcombo @Padraic-O-Mhuiris