chore: fix mpt sync #132
Open
chore: fix mpt sync #132
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <[email protected]>
CodSpeed Performance ReportMerging #132 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
code_sizeis used in extcodesize, and removing it from theAccountlead to a default value value of0to be used for the field when retrieving an account from database and converting it to anrevm::primitives::AccountInfo. This further lead to a sync error (gas used mismatch) at block 3404 because an incorrect code size of 0 was used.In order to reenable syncing in the MPT mode without adding too much diff with upstream, we remove the
code_size"shortcut" that is taken in the Scroll revm fork for theextcodesize, and instead retrieve the code from database and return its length as done in the latest commit on thescroll-evm-executor/reth/v51branch.