-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji autosuggest menu #345
Emoji autosuggest menu #345
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @SaurabhJamadagni! One minor question, do you know why all the .entitlements
files are red? Will merge regardless, but would be nice to get your opinions on those 😊
I didn't understand @andrewtavis sorry. Red as in? |
Sorry for not explaining well, @SaurabhJamadagni! I expected that you’d get what I was talking about as you would be seeing it too. Like those files’ names in my Xcode are red like they have errors. The names of the files in the sidebar, where directories and files have white names normally (or default text color). |
That's weird @andrewtavis. Because they look normal in my version. Let me try to search why this might be happening. Will share soon. |
No stress about it, @SaurabhJamadagni. Likely just a bug in Xcode :) |
Contributor checklist
Description
Hey @andrewtavis, here's my attempt at trying to keep the PRs atomic and issue specific. 😅
Will move on to the functionality implementation for emoji autosuggest menu item next. This PR adds:
Hope this works! Thanks 😄
Related issue