Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji autosuggest menu #345

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

SaurabhJamadagni
Copy link
Collaborator

Contributor checklist


Description

Hey @andrewtavis, here's my attempt at trying to keep the PRs atomic and issue specific. 😅

Will move on to the functionality implementation for emoji autosuggest menu item next. This PR adds:

  • Menu option for toggling emoji autosuggestions
  • Fixes toggle colours

Hope this works! Thanks 😄

Related issue

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review July 20, 2023 18:11
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @SaurabhJamadagni! One minor question, do you know why all the .entitlements files are red? Will merge regardless, but would be nice to get your opinions on those 😊

@andrewtavis andrewtavis merged commit 7021881 into scribe-org:main Jul 20, 2023
@SaurabhJamadagni
Copy link
Collaborator Author

I didn't understand @andrewtavis sorry. Red as in?

@andrewtavis
Copy link
Member

andrewtavis commented Jul 23, 2023

Sorry for not explaining well, @SaurabhJamadagni! I expected that you’d get what I was talking about as you would be seeing it too. Like those files’ names in my Xcode are red like they have errors. The names of the files in the sidebar, where directories and files have white names normally (or default text color).

@SaurabhJamadagni
Copy link
Collaborator Author

Like those files’ names in my Xcode are red like they have errors.

That's weird @andrewtavis. Because they look normal in my version. Let me try to search why this might be happening. Will share soon.

@andrewtavis
Copy link
Member

No stress about it, @SaurabhJamadagni. Likely just a bug in Xcode :)

@andrewtavis andrewtavis added the GSoC Available for Google Summer of Code participants label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Available for Google Summer of Code participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants