Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#142 Centralize data formatting into a single file #514

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

andrewtavis
Copy link
Member

Contributor checklist


Description

This is the work to centralize the formatting process. There are other changes in here as well:

  • Combines languages and sub-languages for list outputs
  • Allows for the passing of sub-language language pairs to the CLI
  • We're no longer hard coding the _1, _2 subquery processes as we were before
    • The max number is derived and queries are tried through this number, where before it was a max of 4

Related issue

Copy link

github-actions bot commented Nov 24, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member Author

I'll merge this in and then we'll go into an active testing phase for the CLI :)

@andrewtavis andrewtavis merged commit ee82994 into main Nov 24, 2024
6 checks passed
@andrewtavis andrewtavis deleted the 142-simplify-formatting branch November 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant