Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract noun gender functions to utils.py #69

Closed
2 tasks done
andrewtavis opened this issue Feb 24, 2024 · 3 comments
Closed
2 tasks done

Extract noun gender functions to utils.py #69

andrewtavis opened this issue Feb 24, 2024 · 3 comments
Assignees
@ikeadeoyin
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Feb 24, 2024 •
edited
Loading

Terms

Description

As a part of refactoring the codebase, it would be great if the map_genders function that's used in various noun formatting processes was extracted to utils.py and reused. This would be done for all currently finished noun formatting processes that have genders, so French, German, Italian, Portuguese, Russian, Spanish and Swedish.

Contribution

Happy to discuss the work to be done and support implementation!
@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 24, 2024
@andrewtavis andrewtavis mentioned this issue Feb 27, 2024
Closed
2 tasks
@ikeadeoyin
Copy link
Contributor

Hello @andrewtavis,
I am interested in working on this.

@ikeadeoyin ikeadeoyin mentioned this issue Feb 27, 2024
Merged
1 task
@andrewtavis
Copy link
Member Author

Assigned, and thanks for all the effort and collaboration so far!

andrewtavis added a commit to ikeadeoyin/Scribe-Data that referenced this issue Mar 17, 2024
@andrewtavis
scribe-org#69 add common nouns, apply to all noun formatting, and add…
7d46618 
… Ruff
@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Mar 17, 2024
@andrewtavis
Copy link
Member Author

Closed via #84 🚀 Thanks so much for the contribution, @ikeadeoyin!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Mar 17, 2024
andrewtavis added a commit that referenced this issue Mar 17, 2024
@andrewtavis
#69 update changelog with information on noun gender mapping function
7231dc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikeadeoyin ikeadeoyin

Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @ikeadeoyin