Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ISO code usage using Python langcodes #55

Closed
2 tasks done
andrewtavis opened this issue Oct 30, 2023 · 4 comments
Closed
2 tasks done

Refactor ISO code usage using Python langcodes #55

andrewtavis opened this issue Oct 30, 2023 · 4 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactor Refactor code to improve quality

Comments

@andrewtavis
Copy link
Member

Terms

Description

Something that I realized while doing a project for work is that there is a Python package langcodes that can handle a lot of the ISO-2 code work we're doing with Scribe-Data. Adding this to the dependencies would also make adding new languages to the data process easier in the future :)

Contribution

Happy to support someone who has interest in working on this!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers refactor Refactor code to improve quality labels Oct 30, 2023
@andrewtavis
Copy link
Member Author

Ping @m-charlton: definitely not the most difficult of issues, but this would be a solid one to pick up for now :) I'll get to the merges soon!

@andrewtavis
Copy link
Member Author

This would basically allow us to remove this data from the JSON once that's merged :)

@shashank-iitbhu
Copy link
Contributor

@andrewtavis I have setup the development environment locally. I can see two functions get_language_iso and get_language_from_iso in src/scribe_data/utlis.py . You can assign me this issue, so that I can go ahead and create a draft PR, Link to the langcodes library.

@andrewtavis
Copy link
Member Author

Thanks @shashank-iitbhu! Really appreciate all the details! Let me know if there's anything I can to do help!

shashank-iitbhu pushed a commit to shashank-iitbhu/Scribe-Data that referenced this issue Jan 16, 2024
Signed-off-by: Shashank Mittal <[email protected]>
andrewtavis added a commit that referenced this issue Jan 27, 2024
fixes #55 : Refactor ISO code usage using Python langcodes
@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactor Refactor code to improve quality
Projects
Archived in project
Development

No branches or pull requests

2 participants