Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Results for Non-existent Language/Data Type in total Command #307

Closed
2 of 4 tasks
catreedle opened this issue Oct 10, 2024 · 5 comments
Closed
2 of 4 tasks
Assignees
Labels
blocked Another issue is blocking bug Something isn't working hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@catreedle
Copy link
Contributor

catreedle commented Oct 10, 2024

Terms

Behavior

When a non-existent language or data type is provided to the total command, the system returns an incorrect number of lexemes instead of a "Not found" message.

Steps to Reproduce:

  1. Run the total command with an invalid language or data type.
  2. Observe that the command returns a number instead of indicating that the language or data type doesn't exist.

bug

Expected Behavior:
When a non-existent language or data type is provided, the command should return a clear message indicating "Total number of lexemes: Not found" instead of returning incorrect results.

Proposed Solution:

  • Add a check function to validate if the provided language and data type exist in the language_metadata or data_type_metadata.
  • If either the language or data type does not exist, the system should return a "Not found" message without executing the query.

This issue is closely related to #295
This issue is blocked by #295

Contribution
I would love to work and collaborate on this.

@catreedle catreedle added the bug Something isn't working label Oct 10, 2024
@catreedle catreedle changed the title [Bug] Incorrect Results for Non-existent Language/Data Type in total Command Incorrect Results for Non-existent Language/Data Type in total Command Oct 10, 2024
@catreedle
Copy link
Contributor Author

Hi @andrewtavis, can you please add the blocked label and assign this to me? Thank you. :)

@andrewtavis andrewtavis added help wanted Extra attention is needed blocked Another issue is blocking hacktoberfest Included as a part of Hacktoberfest labels Oct 10, 2024
@DeleMike
Copy link
Contributor

DeleMike commented Oct 10, 2024

hey @catreedle! could we collaborate on this issue? we could discuss it on Matrix. what do you think?

@catreedle
Copy link
Contributor Author

Hi @DeleMike. Sure thing, I’d be happy to collaborate on this. Just a heads up that it's currently blocked by another issue, but we can still discuss it. :)

@DeleMike
Copy link
Contributor

cool! I'll DM you on Matrix :)

catreedle added a commit to catreedle/Scribe-Data that referenced this issue Oct 13, 2024
andrewtavis added a commit that referenced this issue Oct 13, 2024
add validate language and data type #307
@andrewtavis
Copy link
Member

Closed via #337, with the follow up work in #341 :) Thanks @catreedle!

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another issue is blocking bug Something isn't working hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants