Provide custom palette directly to neogit

[gldtn]

Better integration with Neogit custom palette: https://github.com/NeogitOrg/neogit/blob/0820552997dd4dda4faa147228f0e61ea88290a3/doc/neogit.txt#L563

[scottmckendry]

We need to check if neogit can be loaded before we try to require it. If you don't have the plugin installed, it breaks cyberdream:

Failed to run `config` for cyberdream.nvim

vim/_editor.lua:0: /home/scott/git/nix/nvim/init.lua..nvim_exec2() called at /home/scott/git/nix/nvim/init.lua:0../home/scott/git/cyberdream.nvim/colors/cyberdream.lua: Vim(colorscheme):E5113: Error while calling lua chunk: ...git/cyberdream.nvim/lua/cyberdream/extensions/neogit.lua:8: module 'neogit' not found:
	no field package.preload['neogit']

Suggested change

	local neogit = require("neogit")
	if not package.loaded["neogit"] then
	return {}
	end
	local neogit = require("neogit")

[scottmckendry]

Hey @gldtn!

Thanks for your PR 🙂

Aside from the issue with the require, I'm really liking how this looks. Though I would prefer a scenario where we don't have to make any extra require calls to external plugins.

neogit.setup() worries me most since I'd imagine most people will be lazy-loading Neogit, and colourshemes are always the first plugin that neovim has to load. This will be slowing down cyberdream's load times quite a bit, I'd imagine.

Is there any reason why using the built-it Neogit highlight groups isn't an option here?

[gldtn]

Is there any reason why using the built-it Neogit highlight groups isn't an option here?

The whole reason I changed to the built-in hl groups was to not have to set each group individually and let neogit take care of the rest by simply passing cyberdream colors to it.

I did not think about the possible loading issues as you described above. I believe in order to not require neogit I would maybe have to somewhat replicate some of the items in the hl_store = {} table defined here: https://github.com/NeogitOrg/neogit/blob/0820552997dd4dda4faa147228f0e61ea88290a3/lua/neogit/lib/hl.lua#L152

Let me see what I can come up with when I get home today and I'll give you an update.

[scottmckendry]

You could use Cattpuccin's implementation as a reference:

https://github.com/catppuccin/nvim/blob/f8a155ab5891c5d2fb709b7e85627f1783d5a5d9/lua/catppuccin/groups/integrations/neogit.lua

You probably won't need to define all highlight groups; most default links should be fine to leave as is.

They use darken & lighten helpers for darker and lighter colours for backgrounds etc.

If you want to do something similar you can use blend. There's an example of this here:

https://github.com/scottmckendry/cyberdream.nvim/blob/731290012f435e06e4d5d64ed7c09cec49df2663/lua/cyberdream/extensions/markdown.lua

[gldtn]

This removes .setup() call. Overall Neogit should look much cleaner with this update.

Question, when you set Cyberdream with transparent = true, does fg becomes white if set to t.bg on your terminal? Or is this a normal behavior in Neovim? I'm assuming Cyberdream sets bg to "NONE" if transparency is enabled.

For example:
NeogitCommitViewHeader = { bg = t.cyan, fg = t.bg }

To avoid this I set it to t.bg_solid

I noticed this behavior when customizing my fzf-lua/telescope, I can open a issue to show screenshots if necessary.

Thanks!

[scottmckendry]

Great stuff @gldtn 🙂 thanks again for contributing to the project!