-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Optimizer API harmonization, minuit autodifferentiation support #951
Conversation
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 96.54% 96.65% +0.10%
==========================================
Files 57 59 +2
Lines 3215 3284 +69
Branches 440 447 +7
==========================================
+ Hits 3104 3174 +70
+ Misses 71 69 -2
- Partials 40 41 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b0d68be
to
227494b
Compare
18579bf
to
26a0c01
Compare
26a0c01
to
08a437e
Compare
08a437e
to
6cc2f84
Compare
baad03d
to
bbb15de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not finished with the review yet, but these are things we should patch up. I can help on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think @kratsg has heroically fought with this PR for long enough and we're all happy enough with it as is. I'll approve this and as a reminder to us all we are intentionally breaking the current release tests on master
so that we can get PR #972 in as well before cutting a minor v0.5.0
and moving onto toys in v0.6.0
.
Description
As an example of behavior change:
Docs are built here: https://pyhf.readthedocs.io/en/feat-autogradminuit/
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: