Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concatenate and add missing functionality to backends: #262

Merged
merged 8 commits into from
Sep 14, 2018

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Sep 14, 2018

Description

Add the following functionality to backends in preparation for tensorizing the interpolation code as in #251

  • einsum
  • zeros
  • abs

NB: mxnet does not support einsum. In lieu of this, I added a raise NotImplementedError when einsum is called.

Checklist Before Requesting Approver

  • Tests are passing
  • "WIP" removed from the title of the pull request

@lukasheinrich
Copy link
Contributor

lukasheinrich commented Sep 14, 2018

for background:

this is part of the major rewrite to vectorize pyhf better (#231 and #251) are splitting it into multiple PRs. The vectorization of the interpolation code makes heavy use of the einstein summation-style tensor operations

@kratsg kratsg self-assigned this Sep 14, 2018
@kratsg kratsg added the feat/enhancement New feature or request label Sep 14, 2018
@lukasheinrich
Copy link
Contributor

we should add some tests for einsum and axis-aware concat

@coveralls
Copy link

coveralls commented Sep 14, 2018

Coverage Status

Coverage decreased (-0.1%) to 97.27% when pulling 64f3ac2 on update/addFunctionalityInBackend into 75edf5b on master.

@matthewfeickert
Copy link
Member

Yeah, I agree. This all looks really nice (:+1:), so once tests are in it should be ready to :shipit:.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I see that the push passed the CI).

tests/test_tensor.py Outdated Show resolved Hide resolved
@lukasheinrich
Copy link
Contributor

ok, i'll ignore the .1% decreasein coverage and merge

@lukasheinrich lukasheinrich merged commit b143ffd into master Sep 14, 2018
@lukasheinrich lukasheinrich deleted the update/addFunctionalityInBackend branch September 14, 2018 21:56
@matthewfeickert matthewfeickert mentioned this pull request Sep 15, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants