Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backport): Pass script_runner commands as a single sequence #2222

Merged
merged 1 commit into from
May 23, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 23, 2023

Description

Backport PR #2221

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2221
* Require pytest-console-scripts v1.4.0+ in 'test' extra. pytest-console-scripts v1.4.0
  introduces a DeprecationWarning:
  > script_runner commands should be passed as a single sequence, not as multiple arguments.
  > Replace `script_runner.run(a, b, c)` calls with `script_runner.run([a, b, c])`
* Remove unpacking of the command to be passed to script_runner with shlex.split
  to pass a list and not multiple arguments.

* Require pytest-console-scripts v1.4.0+ in 'test' extra. pytest-console-scripts v1.4.0
  introduces a DeprecationWarning:
  > script_runner commands should be passed as a single sequence, not as multiple arguments.
  > Replace `script_runner.run(a, b, c)` calls with `script_runner.run([a, b, c])`
* Remove unpacking of the command to be passed to script_runner with shlex.split
  to pass a list and not multiple arguments.
@matthewfeickert matthewfeickert added the backport Backport PRs from main to release branch label May 23, 2023
@matthewfeickert matthewfeickert self-assigned this May 23, 2023
@matthewfeickert matthewfeickert added fix A bug fix build Changes that affect the build system or external dependencies labels May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.7.x@b35b863). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2222   +/-   ##
=================================================
  Coverage                  ?   98.30%           
=================================================
  Files                     ?       69           
  Lines                     ?     4532           
  Branches                  ?      802           
=================================================
  Hits                      ?     4455           
  Misses                    ?       45           
  Partials                  ?       32           
Flag Coverage Δ
contrib 27.51% <0.00%> (?)
doctest 61.07% <0.00%> (?)
unittests-3.10 96.31% <0.00%> (?)
unittests-3.11 96.31% <0.00%> (?)
unittests-3.7 96.29% <0.00%> (?)
unittests-3.8 96.33% <0.00%> (?)
unittests-3.9 96.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 8ed99d5 into release/v0.7.x May 23, 2023
@matthewfeickert matthewfeickert deleted the backport/script-runner branch May 23, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch build Changes that affect the build system or external dependencies fix A bug fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant