-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validate workspace specification before accessing parts of it #1953
Merged
matthewfeickert
merged 4 commits into
scikit-hep:master
from
alexander-held:feat/validate-workspace-first
Aug 22, 2022
Merged
feat: Validate workspace specification before accessing parts of it #1953
matthewfeickert
merged 4 commits into
scikit-hep:master
from
alexander-held:feat/validate-workspace-first
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 69 69
Lines 4439 4439
Branches 748 748
=======================================
Hits 4362 4362
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexander-held
commented
Aug 19, 2022
alexander-held
force-pushed
the
feat/validate-workspace-first
branch
from
August 19, 2022 06:19
24c3008
to
37c6546
Compare
alexander-held
requested review from
kratsg,
matthewfeickert and
lukasheinrich
August 19, 2022 06:19
kratsg
approved these changes
Aug 22, 2022
matthewfeickert
approved these changes
Aug 22, 2022
Thanks @alexander-held! We very much appreciate your contributions. :) |
matthewfeickert
changed the title
feat: validate workspace specification before accessing parts of it
feat: Validate workspace specification before accessing parts of it
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The validation of a workspace specification against the schema currently takes place after some aspects of the workspace are already accessed in the constructor of
_ChannelSummaryMixin
. This can lead to unintuitive error messages, which should instead be caught by the schema validation. This PR re-orders the logic such that validation takes place first, ensuring that the relevant information is available for subsequent steps (assuming validation succeeds).resolves #1952
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: