build: Update lower bound on iminuit to v2.7.0 #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was caught in the Minimum supported dependencies workflow after PR #1845 was merged.
Update lower bound on
iminuit
tov2.7.0
as it is the 'oldest' SemVer release that has the behavior (as described in theiminiuit
v2.7.0
changelog):Without this fix, the situation can arise where
Minuit.hesse()
can causeMinuit.valid
to beTrue
when it should beFalse
. Specifically inpyhf/src/pyhf/optimize/opt_minuit.py
Lines 135 to 140 in 2411ed3
during
pyhf/tests/test_pdf.py
Line 1075 in 2411ed3
Also update
tests/constraints.txt
to useiminuit==2.7.0
.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: