docs: Fix download method of probability models archive in impact plot notebook #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e03e050.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I've run the notebook tests with workflow dispatch and they pass. |
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 64 64
Lines 4269 4269
Branches 682 682
=======================================
Hits 4189 4189
Misses 46 46
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
kratsg
approved these changes
Dec 5, 2021
|
I missed that this is happening for the pull plots example notebook too. |
4 tasks
matthewfeickert
added a commit
that referenced
this pull request
Dec 8, 2021
…notebook (#1724) * Use stable DOI https://doi.org/10.17182/hepdata.89408.v3/r2 to download probability models archive from HEPData. * Use `pyhf contrib download` as it can properly accept HEPData headers. * Change directories for the impact plot notebook test so that the paths used in the notebook do not have to be changed to accommodate testing paths. * This PR is complimentary to PR #1721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nightly notebook tests are failing due to the ImpactPlot notebook because of changes in HEPData. Adopting the new DOIs for the probability models and using
pyhf contrib downloadto properly deal with HEPData headers fixes this.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: